Skip to content

Add tests to create shares with only create,delete permissions#35921

Merged
phil-davis merged 1 commit intomasterfrom
share-file-create-delete
Jul 25, 2019
Merged

Add tests to create shares with only create,delete permissions#35921
phil-davis merged 1 commit intomasterfrom
share-file-create-delete

Conversation

@phil-davis
Copy link
Copy Markdown
Contributor

@phil-davis phil-davis commented Jul 25, 2019 •
edited
Loading

Description

Related Issue

#35922

How Has This Been Tested?

Local runs of the acceptance test scenarios.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@phil-davis phil-davis self-assigned this Jul 25, 2019
@karakayasemi
Copy link
Copy Markdown
Contributor

karakayasemi commented Jul 25, 2019

@phil-davis I guess we should open a real issue for this bug, with this way I can add it to #35884's description. I hope this will be also resolved with #35884.

@phil-davis
Copy link
Copy Markdown
Contributor Author

phil-davis commented Jul 25, 2019

@phil-davis I guess we should open a real issue for this bug, with this way I can add it to #35884's description. I hope this will be also resolved with #35884.

yes, I will add an issue now, and put the correct issue number in the scenario tags.

@phil-davis phil-davis mentioned this pull request Jul 25, 2019
Closed
@phil-davis phil-davis force-pushed the share-file-create-delete branch from 85b7b1c to 6c7d4a3 Compare July 25, 2019 07:29
@phil-davis phil-davis marked this pull request as ready for review July 25, 2019 08:00
@phil-davis phil-davis requested a review from individual-it July 25, 2019 08:00
@phil-davis phil-davis mentioned this pull request Jul 25, 2019
Merged
@phil-davis
Copy link
Copy Markdown
Contributor Author

phil-davis commented Jul 25, 2019

Backport stable10 #35924

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 25, 2019

Codecov Report

Merging #35921 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35921   +/-   ##
=========================================
  Coverage      65.8%    65.8%           
  Complexity    18760    18760           
=========================================
  Files          1229     1229           
  Lines         70856    70856           
  Branches       1289     1289           
=========================================
  Hits          46626    46626           
  Misses        23852    23852           
  Partials        378      378
Flag Coverage Δ Complexity Δ
#javascript 53.7% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 67.18% <ø> (ø) 18760 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e208e43...6c7d4a3. Read the comment docs.

1 similar comment
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 25, 2019

Codecov Report

Merging #35921 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35921   +/-   ##
=========================================
  Coverage      65.8%    65.8%           
  Complexity    18760    18760           
=========================================
  Files          1229     1229           
  Lines         70856    70856           
  Branches       1289     1289           
=========================================
  Hits          46626    46626           
  Misses        23852    23852           
  Partials        378      378
Flag Coverage Δ Complexity Δ
#javascript 53.7% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 67.18% <ø> (ø) 18760 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e208e43...6c7d4a3. Read the comment docs.

@phil-davis phil-davis merged commit 794f9b6 into master Jul 25, 2019
@delete-merged-branch delete-merged-branch Bot deleted the share-file-create-delete branch July 25, 2019 09:33
@phil-davis phil-davis mentioned this pull request Jul 25, 2019
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@individual-it individual-it individual-it approved these changes

Assignees

@phil-davis phil-davis

Labels

4 - To release dev:acceptance-tests QA:team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@phil-davis @karakayasemi @individual-it